Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle chaincode pagination #352

Merged
merged 5 commits into from
Dec 8, 2020
Merged

Handle chaincode pagination #352

merged 5 commits into from
Dec 8, 2020

Conversation

Kelvin-M
Copy link
Contributor

@Kelvin-M Kelvin-M commented Nov 26, 2020 •
edited
Loading

Description

The aim of this PR is to handle chaincode pagination for query[Asset]s.

Closes issue(s)

None

Companion PRs

Substra/substra-chaincode#131

How to test / repro

Launch e2e tests, no regression should appear.

Screenshots / Trace

None

Changes include

  • Loop over pagination in call_ledger

Checklist

  • I have tested this code

Other comments

None

@Kelvin-M Kelvin-M mentioned this pull request Nov 26, 2020
Merged
6 tasks
@Kelvin-M Kelvin-M force-pushed the chaincode-pagination branch from 6f4c98d to d06a667 Compare November 27, 2020 12:27
@Kelvin-M Kelvin-M marked this pull request as ready for review November 30, 2020 16:59
@Kelvin-M Kelvin-M force-pushed the chaincode-pagination branch from 6a88139 to 8543e47 Compare December 7, 2020 13:49
inelgnu
inelgnu reviewed Dec 8, 2020
View reviewed changes
Copy link
Member

@inelgnu inelgnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to add a unit test that covers a bookmark use case from the ledger

@Kelvin-M Kelvin-M mentioned this pull request Dec 8, 2020
Merged
3 tasks
@Kelvin-M Kelvin-M requested a review from inelgnu December 8, 2020 09:07
@Kelvin-M Kelvin-M merged commit c3a16ad into master Dec 8, 2020
@Kelvin-M Kelvin-M deleted the chaincode-pagination branch December 8, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inelgnu inelgnu inelgnu approved these changes

@samlesu samlesu Awaiting requested review from samlesu

@AurelienGasser AurelienGasser Awaiting requested review from AurelienGasser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kelvin-M @inelgnu @AurelienGasser